Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadTheDocs config #492

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add ReadTheDocs config #492

merged 1 commit into from
Feb 5, 2025

Conversation

tp832944
Copy link
Contributor

@tp832944 tp832944 commented Feb 5, 2025

refs: #254

PR Type

  • Build related changes

Description

Add configuration file for ReadTheDocs.

How Has This Been Tested?

Untested. We will know when publishing to RtD.

Does this PR introduce a breaking change?

No

Screenshots

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@tp832944 tp832944 self-assigned this Feb 5, 2025
Copy link
Contributor

@rg936672 rg936672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (or at least, looks functionally identical to the one on Coreax!)

@rg936672 rg936672 mentioned this pull request Feb 5, 2025
@rg936672
Copy link
Contributor

rg936672 commented Feb 5, 2025

Ignoring the docs failure here and merging as it's just a link timeout for NeurIPS.

@rg936672 rg936672 merged commit 83c8ae5 into main Feb 5, 2025
29 of 30 checks passed
@rg936672 rg936672 deleted the feature/readthedocs branch February 5, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants