Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.13 #511

Merged
merged 8 commits into from
Feb 20, 2025
Merged

Support Python 3.13 #511

merged 8 commits into from
Feb 20, 2025

Conversation

rg936672
Copy link
Contributor

@rg936672 rg936672 commented Feb 18, 2025 •
edited
Loading

PR Type

  • Feature
  • CI related changes

Description

Closes #447.

How Has This Been Tested?

All CI now runs on Python 3.13.

Does this PR introduce a breaking change?

Yes. Minimum versions for some packages have been increased; notably torch and numpy - we now only support numpy>=2 and torch>=2.6.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@rg936672 rg936672 force-pushed the feature/python-3.13 branch 3 times, most recently from 4469f17 to 1687e8d Compare February 18, 2025 16:32
@rg936672 rg936672 force-pushed the feature/python-3.13 branch from 1687e8d to e5b613d Compare February 19, 2025 10:57
@rg936672
Copy link
Contributor Author

Code coverage failure is a false positive here, IMO.

@tp832944 tp832944 self-requested a review February 20, 2025 11:08
tp832944
tp832944 requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@tp832944 tp832944 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to CHANGELOG.

@rg936672 rg936672 requested a review from tp832944 February 20, 2025 12:29
@tp832944 tp832944 merged commit 4c391cf into main Feb 20, 2025
35 of 36 checks passed
@tp832944 tp832944 deleted the feature/python-3.13 branch February 20, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tp832944 tp832944 tp832944 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.13
2 participants
@rg936672 @tp832944