Initial rework of decorator warnings #515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Decorators now check against a known "safe list" of overrides and new methods before raising a warning. This should reduce the number of spurious warnings that end users see. So far this has only been implemented for
BinaryClassification
aboveVariationalInference
; expanding this to other decorators is left to future PRs.Also improves the warning messages when they are raised, making it clearer exactly where the problem is coming from.
Progresses #123 but does not close it.
How Has This Been Tested?
Existing tests all pass. Added a temporary test to
test_decorator_combinations
to check that no spurious warnings are raised; this test should be incorporated into the general combinations test once implemented for all decorators.Does this PR introduce a breaking change?
No.
Checklist before requesting a review