Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add probabilistic iterative methods #982

Closed
wants to merge 4 commits into from

Conversation

gw265981
Copy link
Contributor

PR Type

  • Feature

Description

Adds the reduce_iterative() method to KernelHerding. Closes #977.

How Has This Been Tested?

Existing tests pass as expected.

New tests introduced with this change verify that reduce_iterative() works correctly. Due to the probabilistic nature of the solver when probabilistic=True, the exact behaviour is hard to verify, hence the test replaces jax.random.choice with a deterministic choice function.

Does this PR introduce a breaking change?

No.

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@gw265981 gw265981 closed this Feb 19, 2025
Copy link
Contributor

Performance review

Commit 6a3dcfd - Merge e0eca31 into 18ef363

No significant changes to performance.

@gw265981 gw265981 deleted the feature/add_probabilistic_iterative_methods branch February 19, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add probabilistic iterative methods
2 participants