Feature/add probabilistic iterative methods #982
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Adds the
reduce_iterative()
method toKernelHerding
. Closes #977.How Has This Been Tested?
Existing tests pass as expected.
New tests introduced with this change verify that
reduce_iterative()
works correctly. Due to the probabilistic nature of the solver whenprobabilistic=True
, the exact behaviour is hard to verify, hence the test replacesjax.random.choice
with a deterministic choice function.Does this PR introduce a breaking change?
No.
Checklist before requesting a review