Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start symmetric decompression #10

Merged
merged 3 commits into from
May 25, 2024
Merged

Start symmetric decompression #10

merged 3 commits into from
May 25, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented May 24, 2024

Compat

  • Bump version to 0.3.2

Source

  • Make a new file matrices.jl for respectful_similar, same_sparsity_pattern
  • Create matrix_versions(A) which lists dense and sparse versions of A, with or without Transpose/Adjoint/Symmetric
  • Simplify checks with color_groups and add more precise warnings
  • Implement decompress_symmetric naively for dense matrices

Tests

  • Test everywhere on the cartesian product of matrix_versions(A) and matrix_versions(S)

@gdalle gdalle marked this pull request as ready for review May 25, 2024 09:03
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 97.80220% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.52%. Comparing base (2c5d35c) to head (804802a).

Files Patch % Lines
src/decompression.jl 92.59% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #10      +/-   ##
===========================================
- Coverage   100.00%   98.52%   -1.48%     
===========================================
  Files            7        9       +2     
  Lines          229      271      +42     
===========================================
+ Hits           229      267      +38     
- Misses           0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit c1b2cf4 into main May 25, 2024
3 of 5 checks passed
@gdalle gdalle deleted the gd/symmetric branch May 25, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant