-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bicoloring #152
Merged
Merged
Bicoloring #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Custom adjacency graph from bipartite * Fix nb edges * More typing
* Start bicoloring result * Working bidirectional decompression * Min diff * Slight perf optim * Perf * Gettin bi * Less code * Fix tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1162 1257 +95
=========================================
+ Hits 1162 1257 +95 ☔ View full report in Codecov by Sentry. |
amontoison
approved these changes
Nov 8, 2024
amontoison
reviewed
Nov 8, 2024
amontoison
reviewed
Nov 8, 2024
amontoison
reviewed
Nov 8, 2024
amontoison
approved these changes
Nov 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
:bidirectional
partitions (so-called bicoloring).:direct
and:substitution
decompression, by relying on the corresponding routines for symmetric matrices.BicoloringResult
preallocates all necessary memory for allocation-free in-place decompression intoA::SparseMatrixCSC
. Decompression intoA::AbstractMatrix
still allocates because we take a submatrix ofA_and_Aᵀ::SparseMatrixCSC
withoutview
.ncolors
which counts distinct colors (mainly useful for bicoloring because one needs to sum rows and columns).Tests
decompression_eltype
values.Chores