Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicoloring #152

Merged
merged 17 commits into from
Nov 8, 2024
Merged

Bicoloring #152

merged 17 commits into from
Nov 8, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Oct 27, 2024

Features

  • Implement coloring, compression and decompression for :bidirectional partitions (so-called bicoloring).
    • It works both for :direct and :substitution decompression, by relying on the corresponding routines for symmetric matrices.
    • The BicoloringResult preallocates all necessary memory for allocation-free in-place decompression into A::SparseMatrixCSC. Decompression into A::AbstractMatrix still allocates because we take a submatrix of A_and_Aᵀ::SparseMatrixCSC without view.
  • Implement visualization for bicoloring results.
  • Export the function ncolors which counts distinct colors (mainly useful for bicoloring because one needs to sum rows and columns).

Tests

  • Add correctness, type stability, allocation and visualization tests for bicoloring.
  • Test for two different decompression_eltype values.

Chores

  • Bump version to v0.4.9

gdalle added 3 commits October 6, 2024 19:49
* Custom adjacency graph from bipartite

* Fix nb edges

* More typing
* Start bicoloring result

* Working bidirectional decompression

* Min diff

* Slight perf optim

* Perf

* Gettin bi

* Less code

* Fix tests
@gdalle gdalle marked this pull request as draft October 27, 2024 20:20
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (42622b5) to head (807330e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #152   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1162      1257   +95     
=========================================
+ Hits          1162      1257   +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review November 6, 2024 06:53
@gdalle gdalle requested a review from amontoison November 6, 2024 06:53
src/decompression.jl Show resolved Hide resolved
src/decompression.jl Show resolved Hide resolved
src/result.jl Outdated Show resolved Hide resolved
src/result.jl Show resolved Hide resolved
src/decompression.jl Outdated Show resolved Hide resolved
@gdalle gdalle merged commit 0246517 into main Nov 8, 2024
6 checks passed
@gdalle gdalle deleted the bicoloring branch November 8, 2024 15:40
@amontoison amontoison mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants