Allocation-free bidirectional decompression #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bicoloring #154 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 13 12 -1
Lines 1261 1256 -5
============================================
- Hits 1261 1256 -5 ☔ View full report in Codecov by Sentry. |
gdalle
added a commit
that referenced
this pull request
Nov 8, 2024
* Implement efficient adjacency graph from bipartite (#145) * Custom adjacency graph from bipartite * Fix nb edges * More typing * Working prototype for bicoloring (coloring + decompression) (#146) * Start bicoloring result * Working bidirectional decompression * Min diff * Slight perf optim * Perf * Gettin bi * Less code * Fix tests * Remove remaining compat * Fix group typing * Avoid accessing ag.S * Add bidirectional coloring visualization (#153) * Allocation-free bidirectional decompression (#154) * Minimize diff * Bump version to 0.4.9 * Check scale for bicoloring visualization * Fix visualization tests * Improve docs * Undo view change * Typo * Add views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SparseMatrixCSCcontainingAandAᵀfor efficient decompression.BicoloringResult.BicoloringResultinto aSparseMatrixCSC, actually decompress into a larger matrixA_and_noAᵀ, which contains the lower triangle ofA_and_Aᵀ. This larger matrix shares the vectorA.nzval, so thatAis updated in-place.SparseMatrixCSCis alloc-free. Decompression into aMatrixstill requires taking the bottom left submatrix ofA_and_noAᵀ(it also could be a view but views of sparse matrices are inefficient).