Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a structurally_biorthogonal check for star bicoloring #155

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

amontoison
Copy link
Collaborator

@amontoison amontoison commented Nov 11, 2024

  • Fix three typos (symmetrix and matric).
  • Add a function proper_length_bicoloring to check the length of the two color vectors returned by a bicoloring.
  • Add a function structurally_biorthogonal based on a "new" definition of star bicoloring.

I don't know if a star bicoloring on A was already defined like this before but it’s something we could easily derive from the definition of a symmetric star coloring on [0 A'; A 0].

I verified this definition of star bicoloring on the problems rectangle and arrowhead.

@amontoison amontoison requested a review from gdalle November 11, 2024 01:51
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0246517) to head (e186a71).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1257      1342   +85     
=========================================
+ Hits          1257      1342   +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title Add a function structurally_biorthogonal for star bicoloring Add a structurally_biorthogonal check for star bicoloring Nov 13, 2024
Copy link
Owner

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@gdalle gdalle merged commit b429209 into main Nov 13, 2024
6 checks passed
@gdalle gdalle deleted the am/biorthogonal branch November 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants