Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compressed visualization #157

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Add compressed visualization #157

merged 4 commits into from
Nov 11, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Nov 11, 2024

  • Change show_colors so that it includes the visualization of the compressed matrix. It now returns a tuple (A_img, B_img) or (A_img, Br_img, Bc_img).
  • Demonstrate compressed visualization in the docs, on a column coloring and on a bidirectional coloring.
  • Test the tail of the tuple (right now only A_img is tested for consistency).

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0246517) to head (23aee47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1257      1308   +51     
=========================================
+ Hits          1257      1308   +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison
Copy link
Collaborator

Can you also support the neutral color 0?
Even if we don't do the postprocessing yet, it will be great to already support it.
We just need to use the color white if we encounter the neutral color or another simple trick.

@gdalle
Copy link
Owner Author

gdalle commented Nov 11, 2024

Can you also support the neutral color 0?

We could but at the moment there are lots of spots where we implicitly assume the colors start at 1. So I don't think it would make much sense to change this only in visualization utilities and not anywhere else. I have opened #158 to keep track of this more general overhaul.

In the meantime I'd rather merge this PR as-is to enable visualization for the blog post, and leave neutral colors for later.

@gdalle gdalle merged commit 1e83716 into main Nov 11, 2024
6 checks passed
@gdalle gdalle deleted the gd/more_viz branch November 11, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants