Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests #16

Merged
merged 3 commits into from
Aug 16, 2023
Merged

add tests #16

merged 3 commits into from
Aug 16, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Aug 14, 2023

@sebastian-goeldi
@SkandanC

TODO:

  • fix MZI code and include test

@joamatab joamatab requested a review from SkandanC August 14, 2023 18:31
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #16 (c7f2285) into main (3097df0) will decrease coverage by 18.61%.
Report is 6 commits behind head on main.
The diff coverage is 86.89%.

❗ Current head c7f2285 differs from pull request most recent head 0fa6826. Consider uploading reports for the commit 0fa6826 to get more accurate results

@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
- Coverage   85.93%   67.32%   -18.61%     
===========================================
  Files          17       18        +1     
  Lines         661      606       -55     
===========================================
- Hits          568      408      -160     
- Misses         93      198      +105     
Files Changed Coverage Δ
kgeneric/cells/straight.py 70.00% <0.00%> (ø)
kgeneric/cells/taper.py 100.00% <ø> (ø)
kgeneric/routing.py 45.45% <45.45%> (ø)
kgeneric/cells/mzi.py 20.77% <60.00%> (-59.49%) ⬇️
kgeneric/cells/bezier.py 81.08% <66.66%> (-0.50%) ⬇️
kgeneric/gpdk.py 87.50% <87.50%> (ø)
kgeneric/layers.py 88.33% <88.33%> (ø)
kgeneric/cells/grating_coupler_elliptical.py 91.66% <95.00%> (ø)
kgeneric/__init__.py 100.00% <100.00%> (ø)
kgeneric/cells/__init__.py 100.00% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 703ee5a into main Aug 16, 2023
6 checks passed
@joamatab joamatab deleted the add_cells branch August 16, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant