refactor(gmeta): gmeta crate removed completely #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazark0x
added
the
A1-inprogress
Lazark0x
added
A0-pleasereview
Base automatically changed from
laz/remove-usage-of-read-state-with-wasm
to
master
February 11, 2025 11:23
# Conflicts: # Cargo.lock # examples/new-meta/build.rs # examples/new-meta/src/lib.rs # examples/new-meta/src/wasm.rs # examples/new-meta/state-v1/build.rs # examples/new-meta/state-v1/src/lib.rs # examples/new-meta/state-v2/build.rs # examples/new-meta/state-v2/src/lib.rs # examples/new-meta/state-v3/build.rs # examples/new-meta/state-v3/src/lib.rs # gcli/src/cmd/program.rs # gcli/src/meta/executor.rs # gcli/src/meta/mod.rs # gcli/src/meta/registry.rs # gcli/src/meta/tests.rs # gcli/tests/cmd/program.rs # gmeta/codegen/src/lib.rs # gmeta/src/lib.rs # gsdk/Cargo.toml # gsdk/src/rpc.rs # utils/cargo-gbuild/src/artifact.rs # utils/wasm-builder/README.md # utils/wasm-builder/src/wasm_project.rs # utils/wasm-optimizer/src/optimize.rs # utils/wasm-proc/src/main.rs
breathx
requested changes
Feb 13, 2025
| @@ -278,7 +278,6 @@ doc: | |||
| @ RUSTDOCFLAGS="--enable-index-page --generate-link-to-definition -Zunstable-options -D warnings" cargo doc --no-deps \ | |||
| -p galloc -p gclient -p gcore -p gear-core-backend \ | |||
| -p gear-core -p gear-core-processor -p gear-lazy-pages -p gear-core-errors \ | |||
| -p gmeta -p gtest -p gear-wasm-builder -p gear-common \ | |||
There was a problem hiding this comment.
oops misclick.... thank you
examples/fungible-token/src/lib.rs
Outdated
| @@ -18,6 +18,8 @@ | |||
|
|
|||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
|
|
|||
| pub use ft_io::*; | |||
There was a problem hiding this comment.
in that case you can deprecate io crate at all
There was a problem hiding this comment.
Maybe in the next pr I should redo the example so that I don't inflate the size of this pr?
| whoami.workspace = true | ||
| reqwest = { workspace = true, default-features = false, features = [ "json", "rustls-tls" ] } | ||
| reqwest = { workspace = true, default-features = false, features = ["json", "rustls-tls"] } | ||
| etc.workspace = true | ||
| runtime-primitives.workspace = true | ||
| url = { workspace = true, features = ["serde"] } |
There was a problem hiding this comment.
wasmer dep seems unused now; if yes, remove it and all related
| assert_ok!(Gear::read_state_impl(program_id, Default::default(), None)); | ||
| assert_ok!(Gear::read_state_using_wasm_impl( |
There was a problem hiding this comment.
cfg test apis (Pallet impl) could be removed as well
There was a problem hiding this comment.
it looks like it's all been deleted
| }} | ||
|
|
||
| #[unsafe(no_mangle)] | ||
| extern "C" fn metahash() {{ |
There was a problem hiding this comment.
are all metahash entries removed as well?
There was a problem hiding this comment.
yes, everything is removed except the api and runtime methods
| @@ -506,22 +390,14 @@ extern "C" fn metahash() {{ | |||
| // Tuple with PathBuf last wasm & opt.wasm | |||
| let mut wasm_paths: Option<(PathBuf, PathBuf)> = None; | |||
There was a problem hiding this comment.
why not? the function still returns tuple with paths to the original wasm and optimized ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gmeta crate removed, cleaned up other crates from gmeta