Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated base of Branch x25519 to OpenSSH v9.8p1 #2

Closed
wants to merge 2 commits into from

Conversation

tttekk
Copy link

@tttekk tttekk commented Aug 26, 2024

Hello. I believe Branch x25519 is based on OpenSSH 9.7p1.
I tried using OpenSSH 9.8p1 ​​as the base.
I hope I can help you in some way.

@geedo0
Copy link
Owner

geedo0 commented Aug 26, 2024

Feel free to submit a PR for this to the upstream repository. My fork exists just to submit PRs to Open Quantum Safe. However, before we can take this contribution I suggest you review my earlier PR which upgraded OQS to 9.7 and follow a similar process which preserved the Git commit history and clearly called out how any/all merge conflicts were resolved.

@tttekk
Copy link
Author

tttekk commented Aug 27, 2024

Thank you for teaching me how to do PR. For the reason that I tried contacting you using a different path, I would prefer your proven version v9.8 (or later version) if possible. In order to study, On the other hand, for study purposes, I will try to trace your PR myself. So, please allow us to use this fork for a while.

@tttekk
Copy link
Author

tttekk commented Aug 28, 2024

Thank you very much for everything. Delete this fork and switch to the upstream fork that you are contributing to. Thank you for your support.

@tttekk tttekk closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants