Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to fix issue #73 and added support for Catalina #83

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

cipaterson
Copy link
Sponsor Contributor

My first pull request... Go easy on me if I've not followed conventions correctly.
I fixed path changes reported in issue #73 for Mojave and added support for Catalina.
Making a Catalina iso works fine for me, but I had to work around the "operation not permitted" error from asr.

@geerlingguy
Copy link
Owner

Remind me if I don't get around to merging this soon :D

@catap
Copy link

catap commented Aug 18, 2021

@geerlingguy 👋

@geerlingguy
Copy link
Owner

lol oops!

@geerlingguy
Copy link
Owner

Hmm... this is conflicting with the addition of Big Sur. Can you rebase with the latest changes?

@catap
Copy link

catap commented Aug 18, 2021

@geerlingguy let ask @cipaterson ! I just read this issues and when I read that you asked to ping you if you forgot about that... well.. I've pinged you :)

@cipaterson
Copy link
Sponsor Contributor Author

@geerlingguy, @catap , I have rebased the Big Sur changes into my fork/branch. My existing pull request should merge clean now.
I don't think the script will produce a Big Sur iso as the other if statements need to be altered too (as Jeff noted). Maybe the way to fix that is to "invert" the if/else causes. i.e. put the latest working case in the else and the code for earlier MacOS installers in explicit if clauses. Like this:
echo Remove Package link and replace with actual files
echo --------------------------------------------------------------------------
if [ "${isoName}" == "Yosemite" ] || [ "${isoName}" == "ElCapitan" || [ "${isoName}" == "Sierra" ] ; then
echo $ rm /Volumes/OS\ X\ Base\ System/System/Installation/Packages
rm /Volumes/OS\ X\ Base\ System/System/Installation/Packages
echo $ cp -rp /Volumes/install_app/Packages /Volumes/OS\ X\ Base\ System/System/Installation/
cp -rp /Volumes/install_app/Packages /Volumes/OS\ X\ Base\ System/System/Installation/
elif [ "${isoName}" == "HighSierra" ] ; then
echo $ ditto -V /Volumes/install_app/Packages /Volumes/OS\ X\ Base\ System/System/Installation/
ditto -V /Volumes/install_app/Packages /Volumes/OS\ X\ Base\ System/System/Installation/
else
echo $ ditto -V /Volumes/install_app/Packages /Volumes/macOS\ Base\ System/System/Installation/
ditto -V /Volumes/install_app/Packages /Volumes/macOS\ Base\ System/System/Installation/
fi
Then any latest installer added has some hope it will just work (if it works like the last version)...

@catap
Copy link

catap commented Aug 19, 2021

@cipaterson I agree with you that this script won't work with Big Sur. Why? Because Big Sur installer contains SharedSupport.dmg instead of InstallESD.dmg and structure is quite different.

@geerlingguy geerlingguy merged commit ee97b8c into geerlingguy:master Aug 19, 2021
@cipaterson cipaterson deleted the add_catalina branch August 20, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants