Add gel as a valid dsn scheme. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoor
reviewed
Nov 27, 2024
internal/client/connutils.go
Outdated
| return nil, nil, fmt.Errorf( | ||
| `scheme is expected to be "edgedb", got %q`, uri.Scheme) | ||
| `scheme is expected to be "edgedb" or "gel", got %q`, uri.Scheme) |
There was a problem hiding this comment.
I think this can just say "gel" and drop "edgedb". We'll still accept "edgedb", but we want people to move away from it so don't mention it as an option.
|
Hm... I also forgot that this also requires a change in the shared-client-testcases. That change is already there so you can update that submodule if you like. Unfortunately this will require that you make all the tests pass and there are a few other new gel related things in the shared-client-testcases changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.