Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema diagnostics in language server #8349

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Schema diagnostics in language server #8349

merged 3 commits into from
Feb 24, 2025

Conversation

aljazerzen
Copy link
Contributor

@aljazerzen aljazerzen commented Feb 19, 2025

Ref #7411

  • adds edb ls sub command, which can be invoked from the vscode extension directly, which makes development much easier,
  • treats both .esdl and .gel files as schema files,
  • keeps track of modified dbschema/ files (even those that have not been saved to fs yet),
  • reports compilation errors from schema (we have previously done that for .edgeql files only)

@aljazerzen aljazerzen requested a review from msullivan February 19, 2025 17:55
Copy link
Contributor

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good to me based on the requests from Sully, so if we feel good about the rest of it, :shipit:

@aljazerzen aljazerzen merged commit a063830 into master Feb 24, 2025
23 checks passed
@aljazerzen aljazerzen deleted the ls-schema branch February 24, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants