Fix FILTER clause MANY warning when FILTER body is a literal set of bools #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools
This is super marginal, but `select 1 filter {true, false}` did not
produce a warning because we only emit the warning when the node has a
span, and we weren't putting a span on `ConstantSet`s.
elprans
approved these changes
Feb 21, 2025
msullivan
added
backported-6.x
msullivan
added a commit
that referenced
this pull request
Feb 21, 2025
…ools (#8364) This is super marginal, but `select 1 filter {true, false}` did not produce a warning because we only emit the warning when the node has a span, and we weren't putting a span on `ConstantSet`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is super marginal, but
select 1 filter {true, false}did notproduce a warning because we only emit the warning when the node has a
span, and we weren't putting a span on
ConstantSets.