add macedo et al 2021 conditional gmm for cav #10421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kslytherin
force-pushed
the
macedo2021
branch
2 times, most recently
from
5a1bbc2 to
9c692e2
Compare
|
@micheles So far my tests pass locally when @emthompson-usgs and I use the command |
|
@kslytherin I don't know whether this will help but my branch with the conditional GMM implementation had got a little out of date with respect to the current master, so I've updated my branch and fixed (for now) the conflicts. Perhaps updating your branch from mine might fix the problem (or flag up the correct error in the tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.