Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount local FHIR cache #47

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Mount local FHIR cache #47

merged 3 commits into from
Feb 27, 2024

Conversation

cybernop
Copy link
Contributor

Contributor Pull Request

Mount local FHIR cache instead of each devcontainer having its own FHIR cache.

Description

Mounts the user specific FHIR cache from ~/.fhir/packages into the dev container at /home/vscode/.fhir/packages. The home directory on the host system is determined using OS environment variables for Windows and *nix and MacOS. By mounting only the .fhir/package sub-directory instead of the whole .fhir directory, container specific FHIR configuration like for codfsh will still be separated for each container.

Motivation and Context

By not having each devcontainer have its own FHIR cache, the required storage space is reduced, and packages don't need to be re-downloaded and inflated again and again.

How has this been tested?

Tested on my local Linux machine and was also used in previous projects on a Windows machine.

Snippets or Screenshots (if necessary):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this IG / specification.
  • My change requires a change to the documentation or narrative (intend) of the IG.
  • I have already updated the documentation / narrative (intend) accordingly.

By not having each devcontainer have its own FHIR cache, the required storage space is reduced and packages don't need to be re-downloaded and inflated again and again.
@cybernop cybernop requested a review from SvenSommer February 21, 2024 11:11
@cybernop cybernop merged commit bba1c00 into main Feb 27, 2024
1 check passed
@cybernop cybernop deleted the feature/mount-local-fhir-cache branch February 27, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants