Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select new observation on creation #4577

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

toddburnside
Copy link
Contributor

@toddburnside toddburnside commented Feb 24, 2025

This PR changes both observation creation and cloning to use AsyncActions instead of the Action that required calls to the API outside of the action. There is also a little cleanup on toasts

@mergify mergify bot added the explore label Feb 24, 2025
Copy link

bundlemon bot commented Feb 24, 2025

BundleMon

Files updated (1)
Status Path Size Limits
index-(hash).js
1.74MB (-468B -0.03%) -
Unchanged files (7)
Status Path Size Limits
exploreworkers-(hash).js
597.86KB -
index-(hash).css
66.25KB -
workbox-window.prod.es5-(hash).js
2.07KB -
agsworker-(hash).js
83B -
plotworker-(hash).js
83B -
catalogworker-(hash).js
81B -
itcworker-(hash).js
81B -

Total files change -468B -0.02%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddburnside toddburnside merged commit 50cdf4b into main Feb 24, 2025
16 checks passed
@toddburnside toddburnside deleted the sc-4768-select-new-observations branch February 24, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants