Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix div by zero #1024

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix div by zero #1024

merged 1 commit into from
Feb 5, 2025

Conversation

tpolecat
Copy link
Member

@tpolecat tpolecat commented Feb 4, 2025

This fixes averageParallacticAngle to work correctly when the observation has zero duration.

@mergify mergify bot added the core label Feb 4, 2025
toddburnside
toddburnside approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@toddburnside toddburnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpolecat tpolecat merged commit ecf6935 into main Feb 5, 2025
9 checks passed
@tpolecat tpolecat deleted the sc-4137-uncaught-error-on-avg-parallactic-calculation branch February 5, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddburnside toddburnside toddburnside approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpolecat @toddburnside