Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut 4779: Filter obsolete acquisition filters #1029

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Shortcut 4779: Filter obsolete acquisition filters #1029

merged 1 commit into from
Feb 28, 2025
+6 −2

Conversation

swalker2m
Copy link
Contributor

I guess we need Resource to do this correctly, but in the meantime ....

@mergify mergify bot added the core label Feb 28, 2025
cquiroz
cquiroz approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cquiroz
Copy link
Collaborator

cquiroz commented Feb 28, 2025

WDYM by Resource in this case?

@swalker2m
Copy link
Contributor Author

WDYM by Resource in this case?

I just mean we won't always be using obsolete flags in enums in core. That is, Resource as a concept (probably just part of the ODB service).

@swalker2m swalker2m merged commit 7793499 into main Feb 28, 2025
9 checks passed
@swalker2m swalker2m deleted the sc-4779-u-prime branch February 28, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swalker2m @cquiroz