Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core and Grackle (Rename DatasetStage enum vals) #942

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

swalker2m
Copy link
Contributor

@swalker2m swalker2m commented Jan 31, 2024

Updates core and grackle. This started as the ODB counterpart to gemini-hlsw/lucuma-core#854 but then evolved into a general update the world PR. Still, the biggest part is updating core for the new dataset event names as agreed upon with Carlos and Javier.

Copy link
Contributor

@toddburnside toddburnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating with the real lucuma-core version.

This was referenced Feb 16, 2024
@swalker2m swalker2m force-pushed the rename-dataset-stage-enum-vals branch from 58e3194 to c3b61de Compare February 23, 2024 15:47
@swalker2m swalker2m changed the title Rename DatasetStage enum vals Update Core and Grackle (Rename DatasetStage enum vals) Feb 23, 2024
@swalker2m swalker2m force-pushed the rename-dataset-stage-enum-vals branch from c3b61de to 88c7b41 Compare February 23, 2024 15:56
@swalker2m swalker2m force-pushed the rename-dataset-stage-enum-vals branch from 89c9b90 to f63a547 Compare February 27, 2024 15:28
@swalker2m swalker2m merged commit c891f1e into main Feb 28, 2024
6 checks passed
@swalker2m swalker2m deleted the rename-dataset-stage-enum-vals branch February 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants