save-build-env: Strip out MAKEOPTS #1311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this might help with https://bugs.gentoo.org/736794 too. |
zmedico
reviewed
Mar 24, 2024
|
The change has been updated to also exclude NINJAOPTS, EPOCHREALTIME, EPOCHSECONDS, and SRANDOM. |
added 2 commits
April 24, 2024 13:16
MAKEOPTS and NINJAOPTS contains a host specific value. If the same package is built on a host with different core counts, the binpkgs will have different hashes. This change drops MAKEOPTS after src_install so that it's not included in final environment.gz. This change also adds them to the special_env_vars.py so that we always have the most up to date version of these variables. Bug: https://bugs.gentoo.org/914441 Bug: https://bugs.gentoo.org/736794 Signed-off-by: Raul E Rangel <[email protected]>
Bash provides access to the time and a random data via variables. We don't want to persist these values when generating a binpkg. Bug: https://bugs.gentoo.org/914441 Signed-off-by: Raul E Rangel <[email protected]>
|
Anything blocking this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAKEOPTS contains a host specific value. If the same package is built on a host with different core counts, the binpkgs will have different hashes. This change drops MAKEOPTS after src_install so that it's not included in final environment.gz.
Bug: https://bugs.gentoo.org/914441
I'm pulling this patch into chromiumos here: https://chromium-review.googlesource.com/c/chromiumos/bazel/+/5356724