Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate field creation between Array and GeoDataType #679

Closed
kylebarron opened this issue Jul 24, 2024 · 0 comments · Fixed by #719
Closed

Deduplicate field creation between Array and GeoDataType #679

kylebarron opened this issue Jul 24, 2024 · 0 comments · Fixed by #719

Comments

@kylebarron
Copy link
Member

This is what tripped up #498, as well as what #646 is hitting. This hit some issues around union data types that have been discussed in geoarrow/geoarrow#43 (comment)
@kylebarron kylebarron mentioned this issue Jul 24, 2024
Closed
This was referenced Aug 23, 2024
Closed
Merged
kylebarron added a commit that referenced this issue Aug 26, 2024
@kylebarron
Fix union array interop (#718)
e6f900b 
### Change list

- Fix DataType creation to match the spec, with hard-coded type ids.
- Don't include geoarrow metadata on underlying arrays when exporting to
arrow-rs. Only include geoarrow metadata on top-level
`geoarrow.geometry` array
- We no longer need a `map` attribute in the struct because the ordering
of the fields is guaranteed by the spec now.
- Don't store underlying arrays under an `Option`

Closes #717, closes
#714

Unblocks #646

Progress towards #679
@kylebarron kylebarron mentioned this issue Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deduplicate field creation geoarrow/geoarrow-rs
1 participant
@kylebarron