New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix union array interop #718

Merged

kylebarron merged 2 commits into main from kyle/union-overhaul-2

Aug 26, 2024

Member

kylebarron commented Aug 26, 2024 •

edited

Loading

Change list

Fix DataType creation to match the spec, with hard-coded type ids.
Don't include geoarrow metadata on underlying arrays when exporting to arrow-rs. Only include geoarrow metadata on top-level geoarrow.geometry array
We no longer need a map attribute in the struct because the ordering of the fields is guaranteed by the spec now.
Don't store underlying arrays under an Option

Closes #717, closes #714

Unblocks #646

Progress towards #679

kylebarron added 2 commits

August 26, 2024 09:40


          Fix union array interop

8f679e7


          Remove underlying Option of arrays

c1984d5

kylebarron enabled auto-merge (squash)

August 26, 2024 14:08

kylebarron merged commit e6f900b into main

22 checks passed

kylebarron deleted the kyle/union-overhaul-2 branch

August 26, 2024 14:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet