Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan and php-cs-fixer: updates #1226

Merged
merged 3 commits into from
May 18, 2024
Merged

phpstan and php-cs-fixer: updates #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43f1048
provider: BingMaps: required and optional params order (phpstan)
kornrunner May 17, 2024
ca9984e
provider: GoogleMaps: required and optional params order (phpstan)
kornrunner May 17, 2024
0ced17f
provider: GeoIP2: php-cs-fixer: fix identation
kornrunner May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Provider/BingMaps/BingMaps.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function getName(): string
return 'bing_maps';
}

private function executeQuery(string $url, ?string $locale = null, int $limit): Collection
private function executeQuery(string $url, ?string $locale = null, int $limit = 1): Collection
{
if (null !== $locale) {
$url = sprintf('%s&culture=%s', $url, str_replace('_', '-', $locale));
Expand Down
16 changes: 8 additions & 8 deletions src/Provider/GeoIP2/Tests/GeoIP2AdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,14 @@ protected function getGeoIP2ModelMock($geoIP2Model)
'city' => [
'geoname_id' => 2911298,
'names' => [
'de' => 'Hamburg',
'en' => 'Hamburg',
'es' => 'Hamburgo',
'fr' => 'Hambourg',
'ja' => 'ハンブルク',
'pt-BR' => 'Hamburgo',
'ru' => 'Гамбург',
'zh-CN' => '汉堡市',
'de' => 'Hamburg',
'en' => 'Hamburg',
'es' => 'Hamburgo',
'fr' => 'Hambourg',
'ja' => 'ハンブルク',
'pt-BR' => 'Hamburgo',
'ru' => 'Гамбург',
'zh-CN' => '汉堡市',
],
],
]
Expand Down
2 changes: 1 addition & 1 deletion src/Provider/GoogleMaps/GoogleMaps.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ private function buildQuery(string $url, ?string $locale = null, ?string $region
* @throws InvalidServerResponse
* @throws InvalidCredentials
*/
private function fetchUrl(string $url, ?string $locale = null, int $limit, ?string $region = null): AddressCollection
private function fetchUrl(string $url, ?string $locale = null, int $limit = 1, ?string $region = null): AddressCollection
{
$url = $this->buildQuery($url, $locale, $region);
$content = $this->getUrlContents($url);
Expand Down