Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return confidence from OpenCage API #1233

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Brammm
Copy link
Contributor

@Brammm Brammm commented Aug 2, 2024

We have a business case where we would need the accuracy/confidence from the providers we are using. This PR adds this for OpenCage.

@freyfogle
Copy link
Contributor

freyfogle commented Aug 2, 2024

HI @Brammm Ed from OpenCage here. Thanks for this change, I am all for it. But one thing for your project, because unfortunately many people get confused by our confidence value - I just want to make sure you understand it is not a measure of "correctness". It is "just" a measure of how large the result is. Please see the details in the API docs.

@Brammm
Copy link
Contributor Author

Brammm commented Aug 3, 2024

Hey @freyfogle, thanks for that heads up, I really appreciate it. We're converting the OpenCage confidence to an generalized "accuracy" in our app, but for our use case, Confidence as defined does work (e.g. with Google Maps, we're using the location type).

@Brammm
Copy link
Contributor Author

Brammm commented Oct 23, 2024

@jbelien Is there anything we can do to help to get this merged? For now, we're relying on a fork.

@Nyholm
Copy link
Member

Nyholm commented Nov 15, 2024

This looks good. Can you please rebase so the CI is running?

@jbelien
Copy link
Member

jbelien commented Feb 16, 2025

@jbelien Is there anything we can do to help to get this merged? For now, we're relying on a fork.

Sorry for the wait ; looks good 👍
Could you rebase your PR to our master branch so I can approve and merge it? Thanks.

@Brammm Brammm force-pushed the opencage-confidence branch from dc8a1bd to bd9f8e2 Compare February 17, 2025 10:50
@Brammm
Copy link
Contributor Author

Brammm commented Feb 17, 2025

@jbelien Donezo! Thanks for following up.

@jbelien jbelien merged commit c7a20cc into geocoder-php:master Feb 18, 2025
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants