Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Photon] Improve locality for city layer & Add layer & radius query params #1245

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

ybert
Copy link
Contributor

@ybert ybert commented Feb 10, 2025

The idea here is to get the city in the PhotonAddress Model when the object returned by Photon is of type "city".
For example : https://photon.komoot.io/reverse?lon=13.38890&lat=52.51644&lang=default&limit=1&layer=city&radius=10

In this example, we don't have the field city returned by Photon because it is the city element itself (so in this case the city/locality name is in the name field).

I also added :

@ybert ybert changed the title Improve locality for city layer & Add layer & radius query params [Photon] Improve locality for city layer & Add layer & radius query params Feb 10, 2025
@jbelien
Copy link
Member

jbelien commented Feb 16, 2025

Thanks for you contribution! Looks good 👍

Could you rebase your PR to our master branch so I can approve and merge it? Thanks.

@ybert ybert force-pushed the photon-improve-results-by-type branch from ee70d31 to 1fa5246 Compare February 16, 2025 10:18
@jbelien jbelien merged commit 4a32622 into geocoder-php:master Feb 16, 2025
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants