Subtract mesh velocity before computing whether a boundary experiences in- or outflow for fixed boundary conditions #6067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #5994, this PR corrects the velocity that is used to determine whether a boundary is an in- or outflow boundary by subtracting the mesh velocity. Otherwise some boundary parts can be considered inflow boundaries and fixed composition will be prescribed, eventhough no inflow occurs, and vice versa.
I have added a new benchmark prm to test these changes, and can turn that into a test.
I would like input on what to do during the 0th and 1st timestep as I had to set the whole boundary to outflow at t0 and t1, because:
For all pull requests:
For new features/models or changes of existing features: