Fix default value of probability density function particle generator #6093
+167
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
force-pushed
the
fix_pdf_default_value
branch
from
c9c20a0
to
5a16741
Compare
gassmoeller
force-pushed
the
fix_pdf_default_value
branch
from
5a16741
to
7419fdc
Compare
bangerth
reviewed
Oct 21, 2024
Comment on lines
+58
to
+60
| // This parameter overwrites one of the parameters in ParsedFunction | ||
| // with a new default value of 1.0. The original default value was 0 | ||
| // everywhere, which is not allowed. |
Co-authored-by: Wolfgang Bangerth <[email protected]>
gassmoeller
force-pushed
the
fix_pdf_default_value
branch
from
76dd166
to
e94c37a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6092 including a changelog entry and one more fix: Previously the default value for the 'probability density function' function expression was 0. This is not a good default, because if the integral of the pdf over the domain is 0 the generator cannot generate particles (and it checks for that and crashes at the moment, thus requiring the user to set a value). This PR changes the default value to 1.0. The nice side effect is that now for all default parameters the 'random uniform' and 'probability density function' generators behave identical. This is expected, because random uniform is just the special case of pdf for a pdf that is constant across the domain.