Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor]: About section various fixes #1034

Merged
merged 8 commits into from
Nov 12, 2024
Merged

[Editor]: About section various fixes #1034

merged 8 commits into from
Nov 12, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Oct 29, 2024

Description

This PR fixes various things in the about section of the editor.

  • Removes the unique identifier field and the record updated field
  • Removes all mentions of the "locked" feature in the fields config
  • Adapts the e2e tests since they cannot get the uuid from the field in the edit page
    ----> Adapting existing command editor_readFormUniqueIdentifier to get the uuid from the URL
    ----> Using new command editor_findDraftInLocalStorage to get the draft records from the localStorage

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Affected libs: common-fixtures, api-metadata-converter, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-editor, feature-auth, ui-search, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Oct 29, 2024

📷 Screenshots are here!

@cmoinier cmoinier force-pushed the ME-about-section-fixes branch 2 times, most recently from 71f65a5 to dde2d71 Compare October 30, 2024 11:25
@coveralls
Copy link

coveralls commented Oct 30, 2024

Coverage Status

coverage: 83.337% (-0.5%) from 83.88%
when pulling 217cf39 on ME-about-section-fixes
into a03dd41 on main.

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmoinier updating the form 👍

I just have two remarks that I think we should take a closer look at.
Let me know if it is not cleat enough.

tools/e2e/commands.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adaptions!

I think the PR is good to go now 🚀

@cmoinier cmoinier merged commit 9ee3821 into main Nov 12, 2024
13 checks passed
@cmoinier cmoinier deleted the ME-about-section-fixes branch November 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants