[Editor]: Bug - Update frequency not kept #1041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the behavior of the updated frequency dropdown, which did not keep the value "2 times per day" upon save & refresh.
The bug only concerned the value "2 times per day", and was due to the fact that in the ISO reader, the mapper for
getUpdateFrequencyFromCustomPeriod
was always going to the casedays <= 7
, even for cases that had 0 days, such as the case "2 times per day", which has the value 0 days and 12 hours.Also, in the
hours
case, theudpatedTimes
value was calculated based on the days count, which is also wrong in this case and should divide the 24 hours with the hours count.Quality Assurance Checklist
breaking change
labelbackport <release branch>
label