Feature/nav fix #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @CarlosMed ! |
|
@CarlosMed FYI I just deployed this with some minor fixes (see updated master) and looks like this breaks (at least on an iPhone). Desktop is fine. The below screenshot illustrates when clicking on the drawer at top left:
|
|
Hmmm, interesting ill look into it and fix it. Edit: Seems like it breaks on safari desktop as well. I'll look at it and see if I can troubleshoot. Bright side it makes it easier to troubleshoot 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes navigation for mobile and desktop which will show the logo on a large screen, hide in medium, and collapsed in a drawer on mobile. This fixes issue #3 and #4