Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Oracle Provider different count query and feature query when a sql_manipulator is used, Issue #1831 #1909

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

Moritz-Langer
Copy link
Contributor

Overview

Description:
Given that a sql_manipulation class is used within the oracle provider, the count query for "numberMatched" and the actual feature queries might be different queries. This can lead to wrong numberMatched and to wrong queries being executed.

Related Issue / discussion

Fixes Issue #1831

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Sorry, something went wrong.

Moritz-Langer and others added 3 commits January 20, 2025 10:48
…y for numberMatched retrieval. Now there queries should be the same in any case. Added a function for less repetitions and added a Test.
@tomkralidis tomkralidis self-requested a review January 22, 2025 16:58
@tomkralidis tomkralidis added the OGC API - Features OGC API - Features label Jan 22, 2025
@tomkralidis tomkralidis added this to the 0.20.0 milestone Jan 22, 2025
@tomkralidis tomkralidis merged commit d9dceac into geopython:master Jan 22, 2025
3 checks passed
@tomkralidis tomkralidis deleted the numbermatched_merge branch January 22, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OGC API - Features OGC API - Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants