Add all remaining predicates: covered by, covers, crosses, overlaps, and touches #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urschrei
commented
Jan 13, 2024
urschrei
commented
Jan 13, 2024
|
We now additionally check that neither of the input geometry dimensions are empty for |
urschrei
changed the title
urschrei
changed the title
michaelkirk
requested changes
Jan 16, 2024
michaelkirk
requested changes
Jan 17, 2024
urschrei
force-pushed
the
more_relate
branch
3 times, most recently
from
46054aa to
45eaef9
Compare
michaelkirk
approved these changes
Jan 23, 2024
covered by, covers, crosses, overlaps, touches
Many thanks for the reviews. Our long national nightmare is over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.I want to do a little more checking with regard to the logic we use to determine whether the input dimensions differ (which is a requirement of theCrossespredicate), and conversely checking whether they're the same (a requirement of theOverlapspredicate). I'm currently doing this by interrogating the IM for the following two relations:a-interior / b-exterioranda-exterior / b-interior. I assert that if they're not equal the input geometry dimensions differ, and vice versa, but I'm not yet 100 % certain that this is true for all valid input geometries.Addressed in af8a50c for all non multi-geometries.