chore: upgrade geos #252
chore: upgrade geos #252
Conversation
Since geos 0.9 was yanked, geozero 0.14.0 no longer builds. Previously, ./geozero-cli (and ./geozero-bench) depended not on the geozero source code in the workspace, but on the published [email protected] Because geozero-cli and geozero-bench could not build [email protected], CI was failing. At least for now, let's have geozero-cli and geozero-bench depend on the local crate, because it fixed this build. Personally, I think it would make sense to _keep_ crates in the workspace using the local source code. But maybe others disagree. In particular, I think I would be very surprised to have geozero-bench actually bench the published geozero crate rather than whats in the working directory. And I think it's good to know when API changes to ./geozero require changes to ./geozero-bench and ./geozero-cli At the point you are making those changes in ./geozero is the best time for you to understand the ramifications of those changes, addressing any "downstream" breakages in the local workspace.
|
I pushed up another commit to fix the build by having workspace crates use the local geozero. Let's see how it goes. /cc @nyurik - you might have feelings about this. Tagging you so you don't think I'm trying to "sneak" it past you. I'm open to other suggestions which solve the problems discussed in my commit. |
|
Very much in agreement with the commit message suggestion FWIW. It's not clear to me why one would want to refer to the published version in this scenario, and it makes maintenance more complex for a small team (which includes people who could not comprehend the RELEASING instructions, i.e. me) |
| @@ -56,4 +56,4 @@ tokio = { version = "1.30.0", default-features = false } | |||
| wkt = "0.12.0" | |||
|
|
|||
| [patch.crates-io] | |||
| #geozero = { path = "./geozero" } | |||
There was a problem hiding this comment.
git blames me for changing this line in e3f6502. I'm with you that a local build should always use ./geozero. 👍
geos@9is yanked. Can you update a new version to crates.io?