Patch netcdf-c to include correct hdf5 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulimoen
force-pushed
the
fix-hdf5-include-directive
branch
from
16fc84f to
1b9b248
Compare
mulimoen
changed the title
mulimoen
force-pushed
the
fix-hdf5-include-directive
branch
2 times, most recently
from
a5efda1 to
b5a6f0c
Compare
mulimoen
force-pushed
the
fix-hdf5-include-directive
branch
from
b5a6f0c to
0d16ffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The include directive of Cmake is weird, and would not pick up the variable we set. The patch forces the correct handling of hdf5 in netcdf-c.
Patch is not needed in upstream where one can set
HDF5_ROOTand it will work correctly.Fixes #139