Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10577: Fix - GFI in identify popup does not trigger when one of the responses is an error #10578

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Oct 2, 2024

Description

This PR fixes the issue with GFI calls not triggered in identify popup when a request end up with an error response

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?
The GFI calls are triggered correctly, even when one of the requests results in an error. The rest of the calls are executed and displayed properly in the identify panel (popup), and subsequent calls are also triggered correctly.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C027-COMUNE_FI-2023-SUPPORT labels Oct 2, 2024
@dsuren1 dsuren1 added this to the 2024.02.01 milestone Oct 2, 2024
@dsuren1 dsuren1 self-assigned this Oct 2, 2024
@tdipisa tdipisa requested a review from MV88 October 2, 2024 07:34
@MV88 MV88 merged commit 64474f4 into geosolutions-it:master Oct 2, 2024
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Oct 2, 2024

@ElenaGallo please test it in DEV

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to 2024.02.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Oct 3, 2024
…hen one of the responses is an error (geosolutions-it#10578)

(cherry picked from commit 64474f4)
tdipisa pushed a commit that referenced this pull request Oct 8, 2024
…responses is an error (#10578) (#10591)

(cherry picked from commit 64474f4)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 8, 2024
offtherailz pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetFeatureInfo in GeoStory does not trigger when one of the responses is an error (Popup)
4 participants