Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit (WIP) #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Initial commit (WIP) #1

wants to merge 3 commits into from

Conversation

max-zilla
Copy link
Collaborator

Not quite ready.

  • move Home screen map and Sidebar to a separate repo
  • move a couple entries to config file to make them generic as possible
  • gd-gltg will be updated to require this component and import, then will only need to override config.jsx

@max-zilla max-zilla requested review from ka7eh and wenjzhu March 11, 2021 16:00
Copy link

@ka7eh ka7eh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick change base on React conventions: can you move the components into src/components and capitalize home.jsx?

import type { Layer as LayerType } from 'ol/layer';

// TODO: Is it possible to make these dynamic? import data struct from config?
import annualYieldData from '../../data/annual_yield.json';
Copy link

@ka7eh ka7eh Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can use urls instead and adjust the code so it fetches the data from the given URLs first and store them either in the component or in redux store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants