feat: improve issue pagination

package.json

@@ -3,7 +3,7 @@
   "private": true,
   "scripts": {
     "build": "nuxt build",
-    "start": "nuxt dev",
+    "start": "nuxt dev --host 0.0.0.0",
     "generate": "nuxt generate",
     "preview": "nuxt preview",
     "postinstall": "nuxt prepare",

server/api/repos/[repo_id]/clone.post.ts

@@ -59,7 +59,7 @@ export default defineEventHandler(async (event) => {
   console.log('fetching issues ...');
   let page = 1;
   while (true) {
-    const { items: issues, total } = await userForgeApi.getIssues(repo.remoteId.toString(), { page, perPage: 50 });
+    const { items: issues, total } = await userForgeApi.getIssues(repo.remoteId.toString(), { page, perPage: 2 });
     for await (const issue of issues) {
       let issueString = `# issue "${issue.title}" (${issue.number})`;
       if (issue.labels.length !== 0) {
@@ -78,8 +78,7 @@ export default defineEventHandler(async (event) => {
 
     console.log('wrote', issues.length, 'issues');
 
-    // TODO: improve stop condition
-    if (issues.length < 50) {
+    if (issues.length < 50 || page === total) {
       break;
     }
     page += 1;

server/forges/github.ts

@@ -139,13 +139,26 @@ export class Github implements Forge {
   async getIssues(token: string, repoId: string, pagination?: Pagination): Promise<PaginatedList<Issue>> {
     const client = this.getClient(token);
 
+    const repo = await client.request(`GET /repositories/{repoId}`, {
+      repoId,
+    });
+
+
     const issues = await client.request(`GET /repos/{owner}/{repo}/issues`, {
-      owner: repoId.split('/')[0],
-      repo: repoId.split('/')[1],
+      owner: repo.data.owner.login,
+      repo: repo.data.name,
       per_page: pagination?.perPage || 10,
       page: pagination?.page || 1,
     });
 
+    let total = 1; //if there are no pages. It occurs when the response doesn't have link attribute in headers
+
+    if(issues.headers.link){
+      const linkToLastPage = issues.headers.link.split(',').find(link=> link.split('; ')[1]==='rel="last"');
+      total = Number(linkToLastPage?.split('&')[1].split('=')[1].split('>')[0]); //e.g <https://api.github.com/repositories/659184353/issues?per_page=2&page=3>; rel="last"
+    }
+
+    console.log(total)
     return {
       items: issues.data.map((issue) => ({
         title: issue.title,
@@ -154,7 +167,7 @@ export class Github implements Forge {
         labels: issue.labels.map((label) => (typeof label === 'string' ? label : label.name || '')),
         comments: [], // TODO: get comments
       })),
-      total: 0, // TODO: get total
+      total,
     };
   }
 }

server/forges/gitlab.ts

@@ -134,10 +134,11 @@ export class Gitlab implements Forge {
   async getIssues(token: string, repoId: string, pagination?: Pagination): Promise<PaginatedList<Issue>> {
     const client = this.getClient(token);
 
-    const issues = await client.Issues.all({
+    const {data: issues,paginationInfo} = await client.Issues.all({
       projectId: repoId,
       perPage: pagination?.perPage || 10,
       page: pagination?.page || 1,
+      showExpanded: true
     });
 
     return {
@@ -148,7 +149,7 @@ export class Gitlab implements Forge {
         labels: issue.labels || [],
         comments: [], // TODO: get comments
       })),
-      total: 0, // TODO: get total
+      total: paginationInfo.total
     };
   }
 }