Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise article #324

Open
wants to merge 1 commit into
base: joss
Choose a base branch
from
Open

Revise article #324

wants to merge 1 commit into from

Conversation

gerlero
Copy link
Owner

@gerlero gerlero commented Mar 3, 2025

As part of openjournals/joss-reviews#7633, make the following proposed changes to the paper.

From #316 (comment)

  • PAPER: Comment on why an external parser was written instead of C++ bindings for OpenFOAM's own parser.
  • PAPER: Mention that looping over a TimeDirectory will iterate over the reconstructed time folders.
  • PAPER: soften language on statement of what files FoamFile can parse & refer readers to FoamFile API docs.
  • PAPER: fix inconsistency numpy.ndarray vs np.ndarray.

From #317 (comment):

  • PAPER: mention other OpenFOAM-related Python packages in the statement of need, including fluidfoam and fluidsimfoam.

From #318 (comment):

  • PAPER: mention hardware used to measure the reported speedup.

@AndreWeiner
Copy link

AndreWeiner commented Mar 6, 2025

@gerlero the PR looks good from my point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants