Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise documentation #326

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revise documentation #326

wants to merge 1 commit into from

Conversation

gerlero
Copy link
Owner

@gerlero gerlero commented Mar 4, 2025

As part of openjournals/joss-reviews#7633, make the following proposed changes to the documentation.

From #316 (comment):

  • DOCS: describe how Slurm-based execution works with AsyncSlurmFoamCase.
  • DOCS: mention that the FoamFile class supports regular expressions, include directives, and other #-based expansions; but does not itself expand these expressions.
  • DOCS: mention that FoamFile does not (currently) support #codeStreams.
  • DOCS: mention that TimeDirectory cell center computation only works with reconstructed meshes.
  • DOCS: mention that non-FoamFile output files are also not supported by the FoamFile class.

From #317 (comment):

  • DOCS: add a realistic, self-contained, use case example.
  • DOCS: add code snippets from README to the relevant docstrings.
  • DOCS: add more elaborate docstrings for main user-facing classes.

From #317 (comment):

This was referenced Mar 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (9627c72) to head (abfc35d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files          15       15           
  Lines        1408     1408           
=======================================
  Hits         1226     1226           
  Misses        182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants