Move minimal version check to discovery file #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
MinimalSupportedVersionfrom update.json and check the minimal supported version from within discovery.json instead.The minimal supported version only affects whether the discovery can be used, so it makes more sense to check it there. The update check and the process for downloading a new binary and installing it is not changed, and not intended to be changed.
This change opens the way to make the update.json checking process async, to be done while the UI is already visible.
In order to make this change, some code had to be moved around. The update code did some calls to the SelfInstaller class to find out the current version number. I moved this code to Settings; that made more sense because it also contains the OAuth client ID and the application name. More things can (and probably should) be moved there, but in this PR I only moved what was necessary for this to work.