Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpc from 1.64.0 to 1.70.1 #363

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Bump grpc from 1.64.0 to 1.70.1 #363

wants to merge 5 commits into from

Conversation

chadlwilson
Copy link
Contributor

@chadlwilson chadlwilson commented Jul 12, 2024

Removes restricting preventing grpc 1.65.0 being installed, in hope that failures on gprc 1.65+ with Ruby 3.3 and Linux/ubuntu have been fixed on grpc 1.65.1.

@gaugebot
Copy link

gaugebot bot commented Jul 17, 2024

@chadlwilson Thank you for contributing to gauge-ruby. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@chadlwilson chadlwilson marked this pull request as ready for review July 17, 2024 04:36
@chadlwilson chadlwilson changed the title Bump grpc from 1.64 to 1.65 Bump grpc from 1.64.0 to 1.65.1 Jul 17, 2024
@chadlwilson chadlwilson marked this pull request as draft July 17, 2024 04:44
@chadlwilson chadlwilson changed the title Bump grpc from 1.64.0 to 1.65.1 Bump grpc from 1.64.0 to 1.65.2 Jul 28, 2024
@chadlwilson chadlwilson force-pushed the grpc-165 branch 2 times, most recently from d52519b to 31d7eb6 Compare August 4, 2024 10:50
@chadlwilson chadlwilson changed the title Bump grpc from 1.64.0 to 1.65.2 Bump grpc from 1.64.0 to 1.66.0 Oct 7, 2024
@chadlwilson chadlwilson force-pushed the grpc-165 branch 2 times, most recently from 9208d15 to 478a834 Compare October 9, 2024 01:13
@chadlwilson chadlwilson changed the title Bump grpc from 1.64.0 to 1.66.0 Bump grpc from 1.64.0 to 1.68.1 Jan 2, 2025
Signed-off-by: Chad Wilson <[email protected]>
@chadlwilson chadlwilson changed the title Bump grpc from 1.64.0 to 1.68.1 Bump grpc from 1.64.0 to 1.70.1 Feb 3, 2025
@chadlwilson
Copy link
Contributor Author

After some actual detailed debugging, this seems to have been caused by something like grpc/grpc#38210 from GRPC 1.65 onwards.

[runner: 1]
        Failed Step: Console should contain following lines in order
        Specification: specs/advanced_topics/continue_on_failure/continue_on_failure_in_setup_teardown.spec:38
        Error Message: java.lang.AssertionError:
        Expecting actual:
          "/Users/chad/Projects/community/gauge/gauge-ruby/lib/gauge_runtime.rb:7: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
        You can add logger to your Gemfile or gemspec to silence this warning.
        warning: parser/current is loading parser/ruby34, which recognizes 3.4.0-compliant syntax, but you are running 3.4.1.
        Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
        I, [2025-02-03T23:30:52.207968 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.230884 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.290603 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.290644 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.300387 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.300434 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.401519 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.401561 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.410624 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.410668 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.431122 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.431830 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.467665 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.467759 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.507503 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.507547 #35837]  INFO -- : schedule another job
        # continueOnFailureSpec
        I, [2025-02-03T23:30:52.709792 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.709870 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.711285 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.711418 #35837]  INFO -- : schedule another job
          ## continueOnFailureScenario
        I, [2025-02-03T23:30:52.713947 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.714022 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.715571 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.715608 #35837]  INFO -- : schedule another job
              * step 1 continue on failure
        I, [2025-02-03T23:30:52.718834 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.718927 #35837]  INFO -- : schedule another job
        I, [2025-02-03T23:30:52.721547 #35837]  INFO -- : deadline is 1970-01-01 07:29:59 +0730; (now=2025-02-03 23:30:52 +0800)
        I, [2025-02-03T23:30:52.721581 #35837]  INFO -- : schedule another job
        checking recoverability for step 1 continue on failure
        Returning response <Gauge::Messages::ExecutionStatusResponse: executionResult: <Gauge::Messages::ProtoExecutionResult: failed: true, recoverableError: true, errorMessage: " exception raised ", stackTrace: "
        > 2 | raise " exception raised "

        /private/var/folders/0m/dw41ln7s3z78vr3jxcxlv6x80000gn/T/continueOnFailure0_18055879216584807806/step_implementations/Name29641637695554120250203233045.rb:2:in 'block in <top (required)>'
        ", screenShot: "", executionTime: 0, message: [], errorType: :ASSERTION, failureScreenshot: "", screenshots: [], failureScreenshotFile: "screenshot-35837-17385966527249.png", screenshotFiles: [], skipScenario: false>>
        W, [2025-02-03T23:30:53.890336 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890511 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890609 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890628 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890636 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890643 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890649 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890660 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890669 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890675 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890681 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890687 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890692 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890697 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890703 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.890708 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891325 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891341 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891347 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891353 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891358 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891363 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891372 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891378 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891384 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891389 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891395 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891400 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891405 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891412 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891418 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891423 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891487 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891536 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891546 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891559 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891566 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891584 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891591 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891597 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891603 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891608 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891614 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891626 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891632 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891637 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891643 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891648 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891653 #35837]  WARN -- : server call failed: request_call completion failed
        W, [2025-02-03T23:30:53.891663 #35837]  WARN -- : server call failed: request_call completion failed

The teste suit manifests failures because when a Gauge Ruby spec fails and throws an exception, the gauge_screenshot plugin is used to capture a screenshot, which forks a process during spec execution and triggers this issue.

Slightly unrelated issue is that I thought screenshot capturing is supposed to be disabled for gauge-tests, but it does in fact seem to be running. Workaround is to disable the screenshot process forking, but since users may fork processes for many reasons in their specs, this does not seem a "proper" fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant