Update for kyo-reactive-stream #1029
Conversation
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
|
About the upstream confusion in the original PR #977, it was my bad to not clarify this at the moment. |
| } | ||
| case Result.Failure(_) => IO(Loop.done(StreamFinishState.StreamCanceled)) | ||
| case Result.Panic(exception) => Abort.panic(exception).andThen(Loop.done(StreamFinishState.StreamCanceled)) | ||
| case Result.Failure(_) => |
There was a problem hiding this comment.
It seems these two cases could be simplified to:
case result => Abort.get(result)
| case _ => IO.unit | ||
| case Result.Success(StreamComplete) => IO(subscriber.onComplete()) | ||
| case Result.Panic(e) => IO(subscriber.onError(e)) | ||
| case _ => IO.unit |
There was a problem hiding this comment.
This case catches Result.Faiure(StreamCanceled), is that the intent? Doesn't the subscriber need to be notified?
There was a problem hiding this comment.
This is intended, cancel can only be called by subscribers, so they should know already. Notifying in here will actually fail a test in reactive-stream-tck
There was a problem hiding this comment.
I'll change this into a concrete branch to be clearer
HollandDM
force-pushed
the
update-interop-stream
branch
from
161d78d to
c61f5e6
Compare
|
Updated! |
/claim #1022
This is an update for post-ack era of
EmitandPollforkyo-reactive-stream