Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix SLF4J log levels #1046

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[core] Fix SLF4J log levels #1046

merged 2 commits into from
Jan 22, 2025

Conversation

hearnadam
Copy link
Collaborator

I noticed that only error was enabled for my Kyo app, when I had it set to info. Info logs should have shown up, but they didn't.

Solution

Check the level of log level enabled in reverse order. In the previous case, error was always enabled (unless off).

Notes

  • I changed Level to a sealed abstract class, enabling exhaustive pattern matching. Avoiding AnyVal is generally better if we know we will only have static instances.
  • I also added a CanEqual for users.

Checklist

  • Unit test all changes
  • Update scaladocs if needed
  • Update the README if needed

@hearnadam hearnadam merged commit 9621701 into getkyo:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants