Hub.init/initWith is Resource #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
approved these changes
Feb 3, 2025
hearnadam
reviewed
Feb 3, 2025
| @@ -251,7 +251,9 @@ object Hub: | |||
| } | |||
| } | |||
| }.map { fiber => | |||
| f(new Hub(channel, fiber, listeners)) | |||
| Resource | |||
| .acquireRelease(new Hub(channel, fiber, listeners))(_.close.unit) | |||
There was a problem hiding this comment.
I think that should be fixed in a separate PR. This means some substantial changes to Resource
There was a problem hiding this comment.
Yep, just making sure you knew!
hearnadam
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1044
Problem
Hubs are initialized with a long-running fiber that should be cleaned up when the hub is no longer being used. This PR makes the initializing methodsinit,initWith, and all overloadsResourceeffects, where the finalizer callsHub#close.Solution
Hub#initWithusesResource.acquireReleaseto construct theHuband calls_.close.unitas the finalizer.Notes