Print methods of the Console effect should not depend on Abort[IOException] #1069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Problem
The Scala
Console.println
doesn't throw anIOException
. The method uses the JavaPrintStream
type, which fails silently in case of errors. So, thekyo.Console
effect should not depend upon anAbort[IOException]
for printing text on the console.We should rewrite the code such that the examples in the documentation will change accordingly:
See PrintWriter and PrintStream never throw IOExceptions for further details.
Solution
I removed the
Abort[IOException]
effect from the return type of thekyo.Console
methods concerning printing. Moreover, I added the following method, which returns whether the output or the error stream behind thescala.Console
encountered anIOException
error: