[core] introduce reactive Signal #1082
Conversation
fwbrasil
force-pushed
the
signal2
branch
2 times, most recently
from
1ef568f to
c1a337f
Compare
| @@ -13,7 +13,7 @@ import kyo.Result | |||
| /** This class provides a jvm-specific implementation of signal handling. It uses reflection to install signal handlers as they may not be | |||
| * available on all implementations of the JVM. | |||
| */ | |||
| private[internal] class SignalPlatformSpecific: | |||
| private[internal] class OSSignalPlatformSpecific: | |||
There was a problem hiding this comment.
How about calling this SignalHandler? OSSIgnal is a bit hard to read.
There was a problem hiding this comment.
I think SignalHandler could still be confusing with the new Signal impl. Maybe it's ok to be more opaque since it's an internal API? Would OsSignal work better?
| * @tparam A | ||
| * The type of value contained in the signal. Must have an instance of `CanEqual[A, A]` | ||
| */ | ||
| abstract class Signal[A](using CanEqual[A, A]): |
There was a problem hiding this comment.
Should this be sealed since we have initRaw?
| * @tparam A | ||
| * The type of value contained in the reference. Must have an instance of `CanEqual[A, A]` | ||
| */ | ||
| final class Ref[A] private[Signal] (_unsafe: Ref.Unsafe[A])(using CanEqual[A, A]) extends Signal[A]: |
There was a problem hiding this comment.
Should we avoid the Ref class name if we plan to have a similar class for an AtomicRef?
There was a problem hiding this comment.
Good point, I think it can be confusing especially given that other effect systems use Ref for the equivalent of Kyo's AtomicRef. FS2 uses SignallingRef but sounds a bit heavyweight to me. Maybe SignalRef exported to the kyo package?
There was a problem hiding this comment.
SignalRef is good with me.
This new effect is in honor of the 600th person to start the repository. Congrats and thank you @diegobernardes!! 🎉
Problem
Kyo doesn't offer a solution to handle reactive signals, which is a common need in UI solutions for example.
Solution
Introduce
Signaltokyo-corewith mutable and constant versions and methods to stream the state.Notes
Signal/SignallingRefbut the implementation is more optimized with two separateAtomicRefs to manage the state and listeners, which reduces allocations.updateAndGet+getAndUpdatefor consistency.