Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: Simplify DataBrew routing #7188

Merged

Conversation

bblommers
Copy link
Collaborator

Simplify request parsing by delegating it to the dispatch-method

The method_dispatch was originally introduced in #6746

@bblommers bblommers added this to the 4.2.13 milestone Jan 5, 2024
@bblommers bblommers added the moto-core PR's that touch the core functionality. This will trigger additional tests. label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac1609) 95.91% compared to head (b7eb62b) 95.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7188   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files         840      840           
  Lines       82681    82633   -48     
=======================================
- Hits        79300    79254   -46     
+ Misses       3381     3379    -2     
Flag Coverage Δ
servertests 35.48% <0.00%> (+0.02%) ⬆️
unittests 95.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers force-pushed the techdebt/simplify-databrew-routing branch from 41c6e85 to b7eb62b Compare January 5, 2024 21:34
@bblommers bblommers merged commit be04fe5 into getmoto:master Jan 5, 2024
37 checks passed
@bblommers bblommers deleted the techdebt/simplify-databrew-routing branch January 5, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moto-core PR's that touch the core functionality. This will trigger additional tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant